开发话题、易盾云接口测试并优化代码

王言钊
1 parent 8f62499f
Showing 20 changed files with 276 additions and 137 deletions
src/main/java/com/cnlive/shenhe/api/AudioControllerApi.java
src/main/java/com/cnlive/shenhe/api/TopicControllerApi.java
src/main/java/com/cnlive/shenhe/api/YiDunControllerApi.java
src/main/java/com/cnlive/shenhe/controller/AudioController.java
src/main/java/com/cnlive/shenhe/controller/ChannelController.java
src/main/java/com/cnlive/shenhe/controller/CommentsController.java
src/main/java/com/cnlive/shenhe/controller/LiveApplyController.java
src/main/java/com/cnlive/shenhe/controller/LiveController.java
src/main/java/com/cnlive/shenhe/controller/TopicController.java
src/main/java/com/cnlive/shenhe/controller/VideosController.java
src/main/java/com/cnlive/shenhe/job/LiveApplyJob.java
src/main/java/com/cnlive/shenhe/job/TopicJob.java
src/main/java/com/cnlive/shenhe/job/YiDunUrlResultJob.java
src/main/java/com/cnlive/shenhe/service/TopicService.java
src/main/java/com/cnlive/shenhe/service/YiDunService.java
src/main/java/com/cnlive/shenhe/service/serviceImpl/AudioServiceImpl.java
src/main/java/com/cnlive/shenhe/service/serviceImpl/ContentServiceImpl.java
src/main/java/com/cnlive/shenhe/service/serviceImpl/TopicServiceImpl.java
src/main/java/com/cnlive/shenhe/service/serviceImpl/VideosServiceImpl.java
src/main/java/com/cnlive/shenhe/service/serviceImpl/YiDunServiceImpl.java
@@ -8,7 +8,7 @@ import com.cnlive.shenhe.entity.ShyAudio;
 import com.cnlive.shenhe.entity.ShyYidun;
 import com.cnlive.shenhe.enums.TextLabels;
 import com.cnlive.shenhe.service.AudioService;
-import com.cnlive.shenhe.service.serviceImpl.YiDunServiceImpl;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.AuditPass;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.YiDunAntiFraudUtil;
@@ -39,7 +39,7 @@ public class AudioControllerApi {
     @Autowired
     AudioService audioService;
     @Autowired
-    YiDunServiceImpl yiDunServiceImpl;
+    YiDunService yiDunService;
     @Autowired
     AuditPass pass;
@@ -126,7 +126,7 @@ public class AudioControllerApi {
                             //2：检测中，3：检测完成，4：检测失败
                             int asrStatus = objectAntispam.getIntValue("asrStatus");
                             String taskId = objectAntispam.getString("taskId");
-                            ShyYidun yiDunMsg = yiDunServiceImpl.getYiDunMsg(taskId);
+                            ShyYidun yiDunMsg = yiDunService.getYiDunMsg(taskId);
                             if (yiDunMsg == null) {
                                 continue;
                             }
@@ -145,16 +145,16 @@ public class AudioControllerApi {
                                 newshyAudio.setReceive(CommonConst.RECEIVE_AUDIT);
                                 pass.audioPass(shyAudio.getAudioId(), 3, shyAudio.getAttr_tags(), "易盾点播音频审核通过了", shyAudio.getCallback());
                             } else {
-                                String labelMsg = "";
+                                StringBuilder labelMsg = new StringBuilder();
                                 if (action != 0 && asrStatus == 3) {
                                     JSONArray labels = objectAntispam.getJSONArray("labels");
-                                    labelMsg = "(";
+                                    labelMsg = new StringBuilder("(");
                                     if (labels != null && labels.size() > 0) {
                                         for (Object labelObj : labels) {
                                             JSONObject jsonObjectone = (JSONObject) labelObj;
                                             Integer label = jsonObjectone.getInteger("label");
                                             String name = TextLabels.getName(label);
-                                            labelMsg = labelMsg + name;
+                                            labelMsg.append(name);
                                         }
                                     }
@@ -183,7 +183,7 @@ public class AudioControllerApi {
                             newshyAudio.setMsg("易盾点播音频审核其它问题需排查");
                             newYiDunMsg.setDesc_msg("易盾点播音频审核其它问题需排查");
                         }
-                        yiDunServiceImpl.updateYiDunMsg(newYiDunMsg);
+                        yiDunService.updateYiDunMsg(newYiDunMsg);
                         audioService.updateAudioMsg(newshyAudio);
                     }
                 }
@@ -4,7 +4,7 @@ import com.alibaba.fastjson.JSONObject;
 import com.cnlive.shenhe.bean.ErrorEnum;
 import com.cnlive.shenhe.bean.ResponseBean;
 import com.cnlive.shenhe.entity.ShyTopic;
-import com.cnlive.shenhe.service.serviceImpl.TopicServiceImpl;
+import com.cnlive.shenhe.service.TopicService;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.CommonUtils;
 import com.cnlive.shenhe.utils.TransitServiceUtils;
@@ -27,7 +27,7 @@ public class TopicControllerApi {
     private static Logger logger = LoggerFactory.getLogger(TopicControllerApi.class);
     @Autowired
-    TopicServiceImpl topicService;
+    TopicService topicService;
     @Autowired
     TransitServiceUtils transitServiceUtils;
@@ -53,7 +53,7 @@ public class TopicControllerApi {
         //判断是否存在
         ShyTopic shyTopic = new ShyTopic();
         shyTopic.setTopic_id(topicId);
-        List<ShyTopic> topicList = topicService.findshyTopic(shyTopic);
+        List<ShyTopic> topicList = topicService.findShyTopic(shyTopic);
         //获取审核类型
         Integer shenheType = topicService.getShenheType(spId);
         if (topicList.size() > 0) {
@@ -104,9 +104,9 @@ public class TopicControllerApi {
         //最后一次更新时间
         shyTopic.setUpdate_date(CommonUtils.getCurrentTime());
         if (shyTopic.getId() == null) {
-            return topicService.impotshyTopic(shyTopic);
+            return topicService.impotShyTopic(shyTopic);
         } else {
-            return topicService.updateshyTopic(shyTopic);
+            return topicService.updateShyTopic(shyTopic);
         }
     }
@@ -152,7 +152,7 @@ public class TopicControllerApi {
             topic.setShenhe_type(CommonConst.AUDIT_TYPE_USER);
             topic.setAuditor_id(null);
         }
-        boolean rs = topicService.updateshyTopic(topic);
+        boolean rs = topicService.updateShyTopic(topic);
         Map<String, Object> ee = new HashMap<>(16);
         ee.put("topic_id", topicId);
         if (rs) {
@@ -2,7 +2,7 @@ package com.cnlive.shenhe.api;
 import com.alibaba.fastjson.JSONObject;
 import com.cnlive.shenhe.entity.ShyYidun;
-import com.cnlive.shenhe.service.serviceImpl.YiDunServiceImpl;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.CommonConstStates;
 import com.cnlive.shenhe.utils.HttpClientUtils;
 import com.cnlive.shenhe.utils.YiDunAntiFraudUtil;
@@ -27,7 +27,7 @@ public class YiDunControllerApi {
     private static Logger logger = LoggerFactory.getLogger(YiDunControllerApi.class);
     @Autowired
-    YiDunServiceImpl yiDunServiceImpl;
+    YiDunService yiDunService;
     /**
      * 网站地址URL产品密钥ID，产品标识
@@ -88,7 +88,7 @@ public class YiDunControllerApi {
             //网页
             shyYidun.setCheck_type(CommonConstStates.WANGYE);
             shyYidun.setCreate_time(new Date());
-            yiDunServiceImpl.addYiDunMsg(shyYidun);
+            yiDunService.addYiDunMsg(shyYidun);
         }
     }
 }
@@ -220,13 +220,13 @@ public class AudioController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] shyAudiods = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyAudioId : shyAudiods) {
-            showMsg = audioService.repulse(shyAudioId, msg, userId);
+            showMsg.append(audioService.repulse(shyAudioId, msg, userId));
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -428,9 +428,9 @@ public class AudioController extends BaseController {
      * 审核结果更新并通知点播音频
      *
      * @param activity_id 音频id（audioId）
-     * @param state      状态码
-     * @param attr_tags  常用审核意见（标签）
-     * @param msg        审核备注
+     * @param state       状态码
+     * @param attr_tags   常用审核意见（标签）
+     * @param msg         审核备注
      * @return
      */
     @PostMapping("/shenheAudio")
@@ -204,10 +204,10 @@ public class ChannelController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] channelIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String channelId : channelIds) {
             ShyChannel channel = channelService.selectByPrimaryKey(Integer.parseInt(channelId));
-            JSONObject result = null;
+            JSONObject result;
             JSONObject json = new JSONObject();
             json.put("channel_id", channel.getChannel_id());
             json.put("state", 4);
@@ -217,18 +217,18 @@ public class ChannelController extends BaseController {
                 result = pass.commentPass(json, channel.getCallback());
             } catch (Exception e) {
                 logger.error("评论回调失败，activity_id:{}", channel.getChannel_id());
-                showMsg = showMsg + "," + channel.getChannel_name() + "的评论拒绝请求失败";
+                showMsg.append(",").append(channel.getChannel_name()).append("的评论拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("评论回调错误，且无返回信息。activity_id:{}", channel.getChannel_id());
-                showMsg = showMsg + "," + channel.getChannel_name() + "的评论拒绝请求失败";
+                showMsg.append(",").append(channel.getChannel_name()).append("的评论拒绝请求失败");
                 break;
             } else {
                 Integer code = result.getInteger("errorCode");
                 if (code != 0) {
                     logger.error("评论回调错误，activity_id:{}，errorCode:{},errorMessage:{}", channel.getChannel_id(), code, result.getString("errorMessage"));
-                    showMsg = showMsg + "," + channel.getChannel_name() + "的评论拒绝请求失败";
+                    showMsg.append(",").append(channel.getChannel_name()).append("的评论拒绝请求失败");
                     break;
                 }
                 channel.setShenhe_status(2);
@@ -237,13 +237,13 @@ public class ChannelController extends BaseController {
                 int i = channelService.updateByPrimaryKeySelective(channel);
                 if (i != 1) {
                     logger.error("评论回调失败，修改结果为0条activity_id:{}", channel.getChannel_id());
-                    showMsg = showMsg + "," + channel.getChannel_name() + "的评论拒绝请求失败";
+                    showMsg.append(",").append(channel.getChannel_name()).append("的评论拒绝请求失败");
                 }
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -246,10 +246,10 @@ public class CommentsController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] commentsIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String commentsId : commentsIds) {
             ShyComments comments = commentsService.selectByPrimaryKey(Integer.parseInt(commentsId));
-            JSONObject result = null;
+            JSONObject result;
             JSONObject json = new JSONObject();
             json.put("activity_id", comments.getActivity_id());
             json.put("state", 4);
@@ -259,18 +259,18 @@ public class CommentsController extends BaseController {
                 result = pass.commentPass(json, comments.getCallback());
             } catch (Exception e) {
                 logger.error("评论回调失败，activity_id:{}", comments.getActivity_id());
-                showMsg = showMsg + "," + comments.getComment_user_name() + "的评论拒绝请求失败";
+                showMsg.append(",").append(comments.getComment_user_name()).append("的评论拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("评论回调错误，且无返回信息。activity_id:{}", comments.getActivity_id());
-                showMsg = showMsg + "," + comments.getComment_user_name() + "的评论拒绝请求失败";
+                showMsg.append(",").append(comments.getComment_user_name()).append("的评论拒绝请求失败");
                 break;
             } else {
                 Integer code = result.getInteger("errorCode");
                 if (code != 0) {
                     logger.error("评论回调错误，activity_id:{}，errorCode:{},errorMessage:{}", comments.getActivity_id(), code, result.getString("errorMessage"));
-                    showMsg = showMsg + "," + comments.getComment_user_name() + "的评论拒绝请求失败";
+                    showMsg.append(",").append(comments.getComment_user_name()).append("的评论拒绝请求失败");
                     break;
                 }
                 comments.setState(2);
@@ -279,13 +279,13 @@ public class CommentsController extends BaseController {
                 int i = commentsService.updateByPrimaryKeySelective(comments);
                 if (i != 1) {
                     logger.error("评论回调失败，修改结果为0条activity_id:{}", comments.getActivity_id());
-                    showMsg = showMsg + "," + comments.getComment_user_name() + "的评论拒绝请求失败";
+                    showMsg.append(",").append(comments.getComment_user_name()).append("的评论拒绝请求失败");
                 }
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -77,7 +77,7 @@ public class LiveApplyController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] shyLiveApplyIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyLiveApplyId : shyLiveApplyIds) {
             ShyLiveapply shyLiveapply = liveApplyService.selectByPrimaryKey(Integer.parseInt(shyLiveApplyId));
             JSONObject result;
@@ -85,29 +85,29 @@ public class LiveApplyController extends BaseController {
                 result = pass.liveApplyPass(shyLiveapply.getActivity_id(), state + 2, msg, msg, shyLiveapply.getCallback());
             } catch (Exception e) {
                 logger.error("直播视频审核失败,id==" + shyLiveApplyId, e);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("直播视频审核失败且接口错误没有返回信息,id==" + shyLiveApplyId);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             Integer code = result.getInteger("errorCode");
             if (code != 0) {
                 logger.error("直播视频审核失败,id:{},code:{}", shyLiveApplyId, code);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " " + result.getString(" errorMessage");
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" ").append(result.getString(" errorMessage"));
                 break;
             }
             int i = liveApplyService.updateLiveApply(Integer.parseInt(shyLiveApplyId), userId, "", state, msg);
             if (i == 0) {
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 更新失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 更新失败");
                 break;
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -265,7 +265,7 @@ public class LiveApplyController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] shyLiveIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyLiveId : shyLiveIds) {
             ShyLiveapply shyLiveapply = liveApplyService.selectByPrimaryKey(Integer.parseInt(shyLiveId));
             JSONObject result;
@@ -273,29 +273,29 @@ public class LiveApplyController extends BaseController {
                 result = pass.liveApplyPass(shyLiveapply.getActivity_id(), 4, msg, msg, shyLiveapply.getCallback());
             } catch (Exception e) {
                 logger.error("直播视频审核失败,id==" + shyLiveId, e);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("直播视频审核失败且接口错误没有返回信息,id==" + shyLiveId);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             Integer code = result.getInteger("errorCode");
             if (code != 0) {
                 logger.error("直播视频审核失败,id:{},code:{}", shyLiveId, code);
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " " + result.getString(" errorMessage");
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" ").append(result.getString(" errorMessage"));
                 break;
-            }
+        }
             int i = liveService.updateLive(Integer.parseInt(shyLiveId), userId, "", 4, msg);
             if (i == 0) {
-                showMsg = showMsg + "," + shyLiveapply.getActivity_id() + " 更新失败";
+                showMsg.append(",").append(shyLiveapply.getActivity_id()).append(" 更新失败");
                 break;
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -72,9 +72,9 @@ public class LiveController extends BaseController {
      * 审核信息返回接口
      *
      * @param activity_id 视频id
-     * @param state      状态码
-     * @param attr_tags  标签
-     * @param msg        备注信息
+     * @param state       状态码
+     * @param attr_tags   标签
+     * @param msg         备注信息
      * @return
      */
     @PostMapping("/shenheVideo")
@@ -275,37 +275,37 @@ public class LiveController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] shyLiveIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyLiveId : shyLiveIds) {
             ShyLive shyLive = liveService.selectByPrimaryKey(Integer.parseInt(shyLiveId));
-            JSONObject result = null;
+            JSONObject result;
             try {
                 result = pass.livePass(shyLive.getActivity_id(), status, msg, msg, shyLive.getCallback());
             } catch (Exception e) {
                 logger.error("直播视频审核失败,id==" + shyLiveId, e);
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("直播视频审核失败且接口错误没有返回信息,id==" + shyLiveId);
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             Integer code = result.getInteger("errorCode");
             if (code != 0) {
                 logger.error("直播视频审核失败,id:{},code:{}", shyLiveId, code);
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " " + result.getString(" errorMessage");
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" ").append(result.getString(" errorMessage"));
                 break;
             }
             int i = liveService.updateLive(Integer.parseInt(shyLiveId), userId, "", status == 3 ? 3 : 4, msg);
             if (i == 0) {
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " 更新失败";
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" 更新失败");
                 break;
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -323,36 +323,36 @@ public class LiveController extends BaseController {
         logger.info("同步直播云信息接口进入");
         ResponseBean responseBean = new ResponseBean();
         String[] shyLiveIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyLiveId : shyLiveIds) {
             ShyLive shyLive = liveService.selectByPrimaryKey(Integer.parseInt(shyLiveId));
-            JSONObject result = null;
+            JSONObject result;
             try {
                 result = pass.syncLive(shyLive.getActivity_id());
             } catch (Exception e) {
                 logger.error("直播云信息同步失败,id==" + shyLiveId, e);
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             if (result == null) {
                 logger.error("直播云信息同步失败且接口错误没有返回信息,id==" + shyLiveId);
-                showMsg = showMsg + "," + shyLive.getActivity_id() + " 拒绝请求失败";
+                showMsg.append(",").append(shyLive.getActivity_id()).append(" 拒绝请求失败");
                 break;
             }
             Integer code = result.getInteger("errorCode");
             if (code != 0) {
                 logger.error("直播云信息同步失败,id:{},code:{}", shyLiveId, code);
-                showMsg = result.getString("errorMessage");
+                showMsg.append(result.getString("errorMessage"));
                 break;
             }
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         } else {
-            showMsg = "直播云信息同步成功";
+            showMsg.append("直播云信息同步成功");
             responseBean.setErrorCode(ErrorEnum.SUCCESS.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -8,7 +8,7 @@ import com.cnlive.shenhe.dto.TopicDTO;
 import com.cnlive.shenhe.entity.ShySites;
 import com.cnlive.shenhe.entity.ShyTopic;
 import com.cnlive.shenhe.service.SitesService;
-import com.cnlive.shenhe.service.serviceImpl.TopicServiceImpl;
+import com.cnlive.shenhe.service.TopicService;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.CommonUtils;
 import com.github.pagehelper.PageInfo;
@@ -38,7 +38,7 @@ public class TopicController extends BaseController {
     private static Logger logger = LoggerFactory.getLogger(TopicController.class);
     @Autowired
-    TopicServiceImpl topicService;
+    TopicService topicService;
     @Autowired
     SitesService sitesService;
@@ -177,7 +177,7 @@ public class TopicController extends BaseController {
         ShyTopic shyTopic = new ShyTopic();
         shyTopic.setShenhe_status(CommonConst.AUDIT_INTT);
         shyTopic.setShenhe_type(CommonConst.AUDIT_TYPE_USER);
-        List<ShyTopic> shyTopicList = topicService.findshyTopic(shyTopic);
+        List<ShyTopic> shyTopicList = topicService.findShyTopic(shyTopic);
         if (shyTopicList != null && shyTopicList.size() > 0) {
             logger.info("您有" + shyTopicList.size() + "条新的话题审核，请注意查看！");
             // 第三个提示框，避免冲突
@@ -553,13 +553,13 @@ public class VideosController extends BaseController {
         String userId = sessionUser.getUserId();
         ResponseBean responseBean = new ResponseBean();
         String[] shyVideoIds = ids.split(",");
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         for (String shyVideoId : shyVideoIds) {
-            showMsg = videosService.repulse(shyVideoId, msg, userId);
+            showMsg.append(videosService.repulse(shyVideoId, msg, userId));
         }
-        if (CommonUtils.isNotEmpty(showMsg)) {
+        if (CommonUtils.isNotEmpty(showMsg.toString())) {
             responseBean.setErrorCode(ErrorEnum.ERROR.getErrorCode());
-            responseBean.setErrorMessage(showMsg);
+            responseBean.setErrorMessage(showMsg.toString());
         }
         return responseBean;
     }
@@ -100,7 +100,8 @@ public class LiveApplyJob {
                 //初始化通知状态
                 Integer noticeState = liveApply.getEmail_notice_state();
                 //初始化通知消息
-                String noticeMsg = liveApply.getEmail_notice_msg();
+                //String noticeMsg = liveApply.getEmail_notice_msg();
+                StringBuilder noticeMsg = new StringBuilder(liveApply.getEmail_notice_msg());
                 //显示spid简称
                 ShySites shySites = sitesService.findspidDescByspid(liveApply.getSp_id());
                 if (CommonUtils.isNotNull(shySites)) {
@@ -131,27 +132,27 @@ public class LiveApplyJob {
                         JSONObject result = JSONObject.parseObject(post.get("result"));
                         if (result == null) {
                             noticeState = CommonConst.NOTICE_FAIL;
-                            noticeMsg = noticeMsg + "\n" + dateTime + " 邮件服务器调用失败,result为空";
+                            noticeMsg.append("\n").append(dateTime).append(" 邮件服务器调用失败,result为空");
                             break;
                         }
                         Integer code = result.getInteger("errorCode");
                         if (code != 0) {
                             noticeState = CommonConst.NOTICE_FAIL;
-                            noticeMsg = noticeMsg + "\n" + dateTime + " 邮件服务器调用失败,result返回消息为：" + result.getString("errorMessage");
+                            noticeMsg.append("\n").append(dateTime).append(" 邮件服务器调用失败,result返回消息为：").append(result.getString("errorMessage"));
                             break;
                         } else {
                             noticeState = CommonConst.NOTICE_SUCCESS;
-                            noticeMsg = noticeMsg + "\n" + dateTime + " 邮件" + emailAddr + "(" + shyEmail.getRemark() + ")发送成功";
+                            noticeMsg.append("\n").append(dateTime).append(" 邮件").append(emailAddr).append("(").append(shyEmail.getRemark()).append(")发送成功");
                         }
                     } catch (Exception e) {
                         logger.info("异常结果为：{}", e.getMessage());
                         noticeState = CommonConst.NOTICE_FAIL;
-                        noticeMsg = noticeMsg + "\n" + dateTime + " 邮件服务器调用失败,服务器报错了";
+                        noticeMsg.append("\n").append(dateTime).append(" 邮件服务器调用失败,服务器报错了");
                         break;
                     }
                 }
                 liveApply.setEmail_notice_state(noticeState);
-                liveApply.setEmail_notice_msg(noticeMsg);
+                liveApply.setEmail_notice_msg(noticeMsg.toString());
                 liveApplyService.updateShyLiveApply(liveApply);
             }
         }
 package com.cnlive.shenhe.job;
 import com.cnlive.shenhe.entity.ShyTopic;
-import com.cnlive.shenhe.service.serviceImpl.TopicServiceImpl;
+import com.cnlive.shenhe.service.TopicService;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.InfoUtil;
 import org.slf4j.Logger;
@@ -22,7 +22,7 @@ public class TopicJob {
     private static Logger logger = LoggerFactory.getLogger(TopicJob.class);
     @Autowired
-    TopicServiceImpl topicService;
+    TopicService topicService;
     @Autowired
     InfoUtil infoUtil;
     @Value("${spring.localhost.url}")
@@ -33,7 +33,7 @@ public class TopicJob {
         ShyTopic shyTopic = new ShyTopic();
         shyTopic.setShenhe_status(CommonConst.AUDIT_INTT);
         shyTopic.setShenhe_type(CommonConst.AUDIT_TYPE_USER);
-        List<ShyTopic> shyTopicList = topicService.findshyTopic(shyTopic);
+        List<ShyTopic> shyTopicList = topicService.findShyTopic(shyTopic);
         if (shyTopicList != null && shyTopicList.size() > 0) {
             logger.info("您有" + shyTopicList.size() + "条新的话题审核，请注意查看！");
             // 设置Headless模式,linux系统下
@@ -7,7 +7,7 @@ import com.cnlive.shenhe.entity.ShyYidun;
 import com.cnlive.shenhe.enums.ImageLabels;
 import com.cnlive.shenhe.enums.TextLabels;
 import com.cnlive.shenhe.service.ContentService;
-import com.cnlive.shenhe.service.serviceImpl.YiDunServiceImpl;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.HttpClientUtils;
 import com.cnlive.shenhe.utils.YiDunAntiFraudUtil;
@@ -47,9 +47,9 @@ public class YiDunUrlResultJob {
     private final static String URL_RESULT = "https://as.dun.163yun.com/v1/crawler/callback/results";
     @Autowired
-    YiDunServiceImpl yiDunServiceImpl;
+    YiDunService yiDunService;
     @Autowired
-    ContentService contentServiceImpl;
+    ContentService contentService;
     /**
@@ -88,7 +88,7 @@ public class YiDunUrlResultJob {
                         try {
                             JSONObject jsonObject = resultJsonArray.getJSONObject(i);
                             String dataId = jsonObject.getString("dataId");
-                            ShyYidun yiDunMsg = yiDunServiceImpl.getYiDunMsg(dataId);
+                            ShyYidun yiDunMsg = yiDunService.getYiDunMsg(dataId);
                             if (yiDunMsg == null) {
                                 continue;
                             }
@@ -105,7 +105,7 @@ public class YiDunUrlResultJob {
                                 newYiDunMsg.setDesc_msg(desc.toString());
                                 newYiDunMsg.setCheck_status(0);
                                 //修改图文状态
-                                contentServiceImpl.callback(String.valueOf(shyContent.getId()), desc.toString(), CommonConst.AUDIT_SUCCESS, "", shyContent.getUpdater());
+                                contentService.callback(String.valueOf(shyContent.getId()), desc.toString(), CommonConst.AUDIT_SUCCESS, "", shyContent.getUpdater());
                                 logger.info("审核云结果回调业务对接方:dataId={}", dataId);
                             } else {
                                 JSONObject evidences = jsonObject.getJSONObject("evidences");
@@ -178,7 +178,7 @@ public class YiDunUrlResultJob {
                                 newYiDunMsg.setDesc_msg(desc.toString());
                                 newYiDunMsg.setCheck_status(2);
                                 //修改图文状态
-                                contentServiceImpl.callback(String.valueOf(shyContent.getId()), desc.toString(), CommonConst.AUDIT_REFUSE, "", shyContent.getUpdater());
+                                contentService.callback(String.valueOf(shyContent.getId()), desc.toString(), CommonConst.AUDIT_REFUSE, "", shyContent.getUpdater());
                             }
                         } catch (NumberFormatException e) {
                             e.printStackTrace();
@@ -190,9 +190,9 @@ public class YiDunUrlResultJob {
                             //拒绝原因
                             shyContent.setShenhe_msg("易盾网站识别其它问题需排查");
                             newYiDunMsg.setDesc_msg("易盾网站识别其它问题需排查");
-                            contentServiceImpl.updateShyContent(shyContent);
+                            contentService.updateShyContent(shyContent);
                         }
-                        yiDunServiceImpl.updateYiDunMsg(newYiDunMsg);
+                        yiDunService.updateYiDunMsg(newYiDunMsg);
                     }
                 }
             }
+package com.cnlive.shenhe.service;
+
+import com.cnlive.shenhe.dto.TopicDTO;
+import com.cnlive.shenhe.entity.ShyTopic;
+import com.github.pagehelper.PageInfo;
+
+import java.util.List;
+
+/**
+ * @Author: yan-zhao-wang
+ * @DateTime: 2022-11-09 9:47
+ */
+public interface TopicService {
+    /**
+     * 获取话题实体对象
+     *
+     * @param shyTopic
+     * @return
+     */
+    ShyTopic getShyTopic(ShyTopic shyTopic);
+
+    /**
+     * 根据条件获取话题列表集合
+     *
+     * @param shyTopic
+     * @return
+     */
+    List<ShyTopic> findShyTopic(ShyTopic shyTopic);
+
+    /**
+     * 修改话题 返回布尔类型
+     *
+     * @param shyTopic
+     * @return
+     */
+    boolean updateShyTopic(ShyTopic shyTopic);
+
+    /**
+     * 导入话题 返回布尔类型
+     *
+     * @param shyTopic
+     * @return
+     */
+    boolean impotShyTopic(ShyTopic shyTopic);
+
+    /**
+     * 分页、条件查询列表
+     *
+     * @param topicDTO
+     * @return
+     */
+    PageInfo<ShyTopic> getPage(TopicDTO topicDTO);
+
+    /**
+     * 话题回调
+     *
+     * @param id
+     * @param msg
+     * @param state
+     * @param userId
+     * @param updater
+     * @return
+     */
+    boolean callback(String id, String msg, Integer state, String userId, String updater);
+
+    /**
+     * 根据主键id查询话题对象
+     *
+     * @param id
+     * @return
+     */
+    ShyTopic selectByPrimaryKey(Integer id);
+
+    /**
+     * 根据主键修改话题对象
+     *
+     * @param topic
+     * @return
+     */
+    int updateByPrimaryKeySelective(ShyTopic topic);
+
+    /**
+     * 获得审核类型
+     *
+     * @param spId
+     */
+    Integer getShenheType(Integer spId);
+}
+package com.cnlive.shenhe.service;
+
+import com.cnlive.shenhe.entity.ShyYidun;
+
+/**
+ * @Author: yan-zhao-wang
+ * @DateTime: 2022-11-09 9:48
+ */
+public interface YiDunService {
+    /**
+     * 添加易盾记录
+     *
+     * @param shyYidun
+     * @return
+     */
+    boolean addYiDunMsg(ShyYidun shyYidun);
+
+    /**
+     * 根据主键id查询易盾对象
+     *
+     * @param dataId
+     * @return
+     */
+    ShyYidun getYiDunMsg(String dataId);
+
+    /**
+     * 根据主键修改易盾对象 返回布尔类型
+     *
+     * @param shyYidun
+     * @return
+     */
+    boolean updateYiDunMsg(ShyYidun shyYidun);
+}
@@ -11,6 +11,7 @@ import com.cnlive.shenhe.mapper.ShyAudioMapper;
 import com.cnlive.shenhe.mapper.ShyUsersMapper;
 import com.cnlive.shenhe.service.AudioService;
 import com.cnlive.shenhe.service.SitesService;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.*;
 import com.github.pagehelper.PageHelper;
 import com.github.pagehelper.PageInfo;
@@ -49,7 +50,7 @@ public class AudioServiceImpl implements AudioService {
     @Autowired
     SitesService sitesService;
     @Autowired
-    YiDunServiceImpl yiDunServiceImpl;
+    YiDunService yiDunService;
     @Value("${yiDun_audio_callback}")
     String yiDun_audio_callback;
@@ -208,34 +209,34 @@ public class AudioServiceImpl implements AudioService {
     @Override
     public String repulse(String shyAudioId, String msg, String userId) {
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         ShyAudio shyAudio = audioService.selectByPrimaryKey(Integer.parseInt(shyAudioId));
         JSONObject result;
         try {
             result = pass.audioPass(shyAudio.getAudioId(), 4, msg, msg, shyAudio.getCallback());
         } catch (Exception e) {
             logger.error("音频审核失败,id==" + shyAudioId, e);
-            showMsg = showMsg + "," + shyAudio.getAudioTitle() + " 拒绝请求失败";
-            return showMsg;
+            showMsg.append(",").append(shyAudio.getAudioTitle()).append(" 拒绝请求失败");
+            return showMsg.toString();
         }
         if (result == null) {
             logger.error("音频审核失败且接口错误没有返回信息,id==" + shyAudioId);
-            showMsg = showMsg + "," + shyAudio.getAudioTitle() + " 拒绝请求失败";
-            return showMsg;
+            showMsg.append(",").append(shyAudio.getAudioTitle()).append(" 拒绝请求失败");
+            return showMsg.toString();
         }
         Integer code = result.getInteger("code");
         if (code != 0) {
             logger.error("音频审核失败,id:{},code:{}", shyAudioId, code);
-            showMsg = showMsg + "," + shyAudio.getAudioTitle() + " " + result.getString("msg");
-            return showMsg;
+            showMsg.append(",").append(shyAudio.getAudioTitle()).append(" ").append(result.getString("msg"));
+            return showMsg.toString();
         }
         //0.未审核,1:已审核,2.拒绝
         int i = audioService.updateAudio(Integer.parseInt(shyAudioId), userId, null, "", 2, msg);
         if (i == 0) {
-            showMsg = showMsg + "," + shyAudio.getAudioTitle() + " 更新失败";
-            return showMsg;
+            showMsg.append(",").append(shyAudio.getAudioTitle()).append(" 更新失败");
+            return showMsg.toString();
         }
-        return showMsg;
+        return showMsg.toString();
     }
     /**
@@ -431,7 +432,7 @@ public class AudioServiceImpl implements AudioService {
             shyYidun.setTask_id(taskId);
             shyYidun.setData_id(dataId);
             shyYidun.setCheck_type(CommonConstStates.DIANBOYINPIN);
-            yiDunServiceImpl.addYiDunMsg(shyYidun);
+            yiDunService.addYiDunMsg(shyYidun);
         }
     }
 }
@@ -8,6 +8,7 @@ import com.cnlive.shenhe.mapper.ShyContentMapper;
 import com.cnlive.shenhe.mapper.ShyUsersMapper;
 import com.cnlive.shenhe.service.ContentService;
 import com.cnlive.shenhe.service.SitesService;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.*;
 import com.github.pagehelper.PageHelper;
 import com.github.pagehelper.PageInfo;
@@ -42,7 +43,7 @@ public class ContentServiceImpl implements ContentService {
     @Autowired
     VideosServiceImpl videosService;
     @Autowired
-    YiDunServiceImpl yiDunServiceImpl;
+    YiDunService yiDunService;
     /**
@@ -465,7 +466,7 @@ public class ContentServiceImpl implements ContentService {
                 shyYidun.setContent_id(shyContent.getId().toString());
                 shyYidun.setCreate_time(new Date());
                 logger.info("审核云保存到ShyYidun表里数据:{}", JSON.toJSONString(shyYidun));
-                yiDunServiceImpl.addYiDunMsg(shyYidun);
+                yiDunService.addYiDunMsg(shyYidun);
             }
         } catch (Exception e) {
             e.printStackTrace();
@@ -6,6 +6,7 @@ import com.cnlive.shenhe.dto.TopicDTO;
 import com.cnlive.shenhe.entity.ShyTopic;
 import com.cnlive.shenhe.mapper.ShyTopicMapper;
 import com.cnlive.shenhe.service.SitesService;
+import com.cnlive.shenhe.service.TopicService;
 import com.cnlive.shenhe.utils.CommonConst;
 import com.cnlive.shenhe.utils.CommonUtils;
 import com.cnlive.shenhe.utils.TransitServiceUtils;
@@ -26,7 +27,7 @@ import java.util.List;
  * @Description:
  */
 @Service
-public class TopicServiceImpl {
+public class TopicServiceImpl implements TopicService {
     private static Logger logger = LoggerFactory.getLogger(TopicServiceImpl.class);
     @Autowired
@@ -36,6 +37,13 @@ public class TopicServiceImpl {
     @Autowired
     SitesService sitesService;
+    /**
+     * 获取话题实体对象
+     *
+     * @param shyTopic
+     * @return
+     */
+    @Override
     public ShyTopic getShyTopic(ShyTopic shyTopic) {
         List<ShyTopic> shyTopicList = shyTopicMapper.select(shyTopic);
         if (CommonUtils.isNotNull(shyTopicList) && shyTopicList.size() > 0) {
@@ -50,7 +58,8 @@ public class TopicServiceImpl {
      * @param shyTopic
      * @return
      */
-    public List<ShyTopic> findshyTopic(ShyTopic shyTopic) {
+    @Override
+    public List<ShyTopic> findShyTopic(ShyTopic shyTopic) {
         return shyTopicMapper.selectByRowBounds(shyTopic, new RowBounds(0, 100));
     }
@@ -60,7 +69,8 @@ public class TopicServiceImpl {
      * @param shyTopic
      * @return
      */
-    public boolean updateshyTopic(ShyTopic shyTopic) {
+    @Override
+    public boolean updateShyTopic(ShyTopic shyTopic) {
         int result = shyTopicMapper.updateByPrimaryKey(shyTopic);
         return result != 0;
     }
@@ -71,7 +81,8 @@ public class TopicServiceImpl {
      * @param shyTopic
      * @return
      */
-    public boolean impotshyTopic(ShyTopic shyTopic) {
+    @Override
+    public boolean impotShyTopic(ShyTopic shyTopic) {
         int result = shyTopicMapper.insertSelective(shyTopic);
         return result != 0;
     }
@@ -82,6 +93,7 @@ public class TopicServiceImpl {
      * @param topicDTO
      * @return
      */
+    @Override
     public PageInfo<ShyTopic> getPage(TopicDTO topicDTO) {
         logger.info("接受参数列表为，TopicDTO:{}", JSON.toJSONString(topicDTO));
         Example example = new Example(ShyTopic.class);
@@ -139,6 +151,7 @@ public class TopicServiceImpl {
      * @param updater
      * @return
      */
+    @Override
     public boolean callback(String id, String msg, Integer state, String userId, String updater) {
         boolean success;
         ShyTopic topic = shyTopicMapper.selectByPrimaryKey(Integer.parseInt(id));
@@ -178,6 +191,7 @@ public class TopicServiceImpl {
      * @param id
      * @return
      */
+    @Override
     public ShyTopic selectByPrimaryKey(Integer id) {
         return shyTopicMapper.selectByPrimaryKey(id);
     }
@@ -188,6 +202,7 @@ public class TopicServiceImpl {
      * @param topic
      * @return
      */
+    @Override
     public int updateByPrimaryKeySelective(ShyTopic topic) {
         return shyTopicMapper.updateByPrimaryKeySelective(topic);
     }
@@ -197,6 +212,7 @@ public class TopicServiceImpl {
      *
      * @param spId
      */
+    @Override
     public Integer getShenheType(Integer spId) {
         //获取图文免审sp
         List<Integer> sites = sitesService.getBusinessList(CommonConst.BUSINESS_TOPIC);
@@ -15,6 +15,7 @@ import com.cnlive.shenhe.mapper.ShyVideosMapper;
 import com.cnlive.shenhe.service.ShyActivityService;
 import com.cnlive.shenhe.service.SitesService;
 import com.cnlive.shenhe.service.UsersfreeService;
+import com.cnlive.shenhe.service.YiDunService;
 import com.cnlive.shenhe.utils.*;
 import com.github.pagehelper.PageHelper;
 import com.github.pagehelper.PageInfo;
@@ -52,7 +53,7 @@ public class VideosServiceImpl {
     @Autowired
     private UsersfreeService usersfreeService;
     @Autowired
-    private YiDunServiceImpl yiDunServiceImpl;
+    private YiDunService yiDunService;
     @Autowired
     private ShyActivityService shyActivityService;
     @Value("${qn_domain}")
@@ -422,7 +423,7 @@ public class VideosServiceImpl {
             shyYidun.setCheck_type(CommonConstStates.TUPIAN);
             shyYidun.setDuration(shyVideos.getDuration());
             shyYidun.setCreate_time(new Date());
-            yiDunServiceImpl.addYiDunMsg(shyYidun);
+            yiDunService.addYiDunMsg(shyYidun);
         } catch (Exception e) {
             e.printStackTrace();
         }
@@ -536,33 +537,33 @@ public class VideosServiceImpl {
      * @return
      */
     public String repulse(String shyVideoId, String msg, String userId) {
-        String showMsg = "";
+        StringBuilder showMsg = new StringBuilder();
         ShyVideos shyVideos = videosService.selectByPrimaryKey(Integer.parseInt(shyVideoId));
         JSONObject result;
         try {
             result = pass.auditPass(shyVideos.getVideo_id(), 4, msg, msg, shyVideos.getCallback());
         } catch (Exception e) {
             logger.error("视频审核失败,id==" + shyVideoId, e);
-            showMsg = showMsg + "," + shyVideos.getVideo_title() + " 拒绝请求失败";
-            return showMsg;
+            showMsg.append(",").append(shyVideos.getVideo_title()).append(" 拒绝请求失败");
+            return showMsg.toString();
         }
         if (result == null) {
             logger.error("视频审核失败且接口错误没有返回信息,id==" + shyVideoId);
-            showMsg = showMsg + "," + shyVideos.getVideo_title() + " 拒绝请求失败";
-            return showMsg;
+            showMsg.append(",").append(shyVideos.getVideo_title()).append(" 拒绝请求失败");
+            return showMsg.toString();
         }
         Integer code = result.getInteger("code");
         if (code != 0) {
             logger.error("视频审核失败,id:{},code:{}", shyVideoId, code);
-            showMsg = showMsg + "," + shyVideos.getVideo_title() + " " + result.getString("msg");
-            return showMsg;
+            showMsg.append(",").append(shyVideos.getVideo_title()).append(" ").append(result.getString("msg"));
+            return showMsg.toString();
         }
         int i = videosService.updateVideo(Integer.parseInt(shyVideoId), userId, null, "", 2, msg);
         if (i == 0) {
-            showMsg = showMsg + "," + shyVideos.getVideo_title() + " 更新失败";
-            return showMsg;
+            showMsg.append(",").append(shyVideos.getVideo_title()).append(" 更新失败");
+            return showMsg.toString();
         }
-        return showMsg;
+        return showMsg.toString();
     }
 }
@@ -3,6 +3,7 @@ package com.cnlive.shenhe.service.serviceImpl;
 import com.alibaba.fastjson.JSON;
 import com.cnlive.shenhe.entity.ShyYidun;
 import com.cnlive.shenhe.mapper.ShyYidunMapper;
+import com.cnlive.shenhe.service.YiDunService;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -13,7 +14,7 @@ import org.springframework.stereotype.Service;
  * @Date: 2020/3/27 17:31
  */
 @Service
-public class YiDunServiceImpl {
+public class YiDunServiceImpl implements YiDunService {
     private static Logger logger = LoggerFactory.getLogger(YiDunServiceImpl.class);
@@ -26,13 +27,11 @@ public class YiDunServiceImpl {
      * @param shyYidun
      * @return
      */
+    @Override
     public boolean addYiDunMsg(ShyYidun shyYidun) {
         logger.info("URL:{}", JSON.toJSONString(shyYidun.getUrl()));
         int result = shyYidunMapper.insert(shyYidun);
-        if (result == 0) {
-            return false;
-        }
-        return true;
+        return result != 0;
     }
     /**
@@ -41,6 +40,7 @@ public class YiDunServiceImpl {
      * @param dataId
      * @return
      */
+    @Override
     public ShyYidun getYiDunMsg(String dataId) {
         return shyYidunMapper.selectByPrimaryKey(dataId);
     }
@@ -51,11 +51,9 @@ public class YiDunServiceImpl {
      * @param shyYidun
      * @return
      */
+    @Override
     public boolean updateYiDunMsg(ShyYidun shyYidun) {
         int result = shyYidunMapper.updateByPrimaryKeySelective(shyYidun);
-        if (result == 0) {
-            return false;
-        }
-        return true;
+        return result != 0;
     }
 }